Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17023#discussion_r102619054
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/json/JsonFileFormat.scala
---
@@ -102,6 +102,15 @@ class JsonFileFormat extends TextBasedFileFormat with
DataSourceRegister {
sparkSession.sessionState.conf.sessionLocalTimeZone,
sparkSession.sessionState.conf.columnNameOfCorruptRecord)
+ // Check a field requirement for corrupt records here to throw an
exception in a driver side
+ dataSchema.getFieldIndex(parsedOptions.columnNameOfCorruptRecord).map
{ corruptFieldIndex =>
--- End diff --
ideally the `columnNameOfCorruptRecord` stuff has nothing to do with
parser. Parser just parses the record and report error if some records are bad,
and the upper-level will handle the bad records and may put the bad record in a
special string column.
I'm ok to keep this code snippet duplicated in 2 places.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
