Github user MLnick commented on the issue:
https://github.com/apache/spark/pull/17000
@ZunwenYou yes I understand that the `sliceAggregate` is different from
SPARK-19634 and more comparable to `treeAggregate`. But I'm not sure, if we
plan to port the vector summary to use `DataFrame` based UDAF, whether we can
incorporate the benefit of `sliceAggregate`.
So my point would probably be to try to see how much benefit accrues from
(a) using UDAF mechanism and (b) not computing unnecessary things. Then we can
compare to the benefit here and decide.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
