Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16996#discussion_r102808290
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/internal/SharedState.scala ---
@@ -61,6 +62,9 @@ private[sql] class SharedState(val sparkContext:
SparkContext) extends Logging {
// When neither spark.sql.warehouse.dir nor
hive.metastore.warehouse.dir is set,
// we will set hive.metastore.warehouse.dir to the default value of
spark.sql.warehouse.dir.
val sparkWarehouseDir = sparkContext.conf.get(WAREHOUSE_PATH)
+ logInfo(s"Setting hive.metastore.warehouse.dir ($hiveWarehouseDir)
to the value of " +
+ s"${WAREHOUSE_PATH.key} ('$sparkWarehouseDir').")
+ sparkContext.hadoopConfiguration.set("hive.metastore.warehouse.dir",
sparkWarehouseDir)
sparkContext.conf.set("hive.metastore.warehouse.dir",
sparkWarehouseDir)
--- End diff --
how about `sparkContext.conf.remove("hive.metastore.warehouse.dir")`? it's
good to have a single source of truth.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
