Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/16855#discussion_r102860963
--- Diff:
core/src/test/scala/org/apache/spark/scheduler/TaskSetManagerSuite.scala ---
@@ -664,6 +665,55 @@ class TaskSetManagerSuite extends SparkFunSuite with
LocalSparkContext with Logg
assert(thrown2.getMessage().contains("bigger than
spark.driver.maxResultSize"))
}
+ test("taskSetManager should not send Resubmitted tasks after being a
zombie") {
+ // Regression test for SPARK-13931
+ val conf = new SparkConf().set("spark.speculation", "true")
+ sc = new SparkContext("local", "test", conf)
+
+ val sched = new FakeTaskScheduler(sc, ("execA", "host1"), ("execB",
"host2"))
+ sched.initialize(new FakeSchedulerBackend() {
+ override def killTask(taskId: Long, executorId: String,
interruptThread: Boolean): Unit = {}
+ })
+
+ // count for Resubmitted tasks
+ var resubmittedTasks = 0
+ val dagScheduler = new FakeDAGScheduler(sc, sched) {
--- End diff --
I see I played around with this a bit and the problem is that the
TaskSetManager also sends an ExecutorLost task failure for the task that gets
resubmitted, so that failure overrides the saved Resubmitted task end reason.
It's fine to leave the existing test, but can you just add a comment that says
something like "Keep track of the number of tasks that are resubmitted, so that
the test can check that no tasks were resubmitted."
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
