GitHub user BryanCutler opened a pull request: https://github.com/apache/spark/pull/17048
[SPARK-14772][PYTHON][ML] Fixed Params.copy method to match Scala implementation ## What changes were proposed in this pull request? Fixed the PySpark Params.copy method to behave like the Scala implementation. The main issue was that it did not account for the _defaultParamMap and merged it into the explicitly created param map. ## How was this patch tested? Added new unit test to verify the copy method behaves correctly for copying uid, explicitly created params, and default params. You can merge this pull request into a Git repository by running: $ git pull https://github.com/BryanCutler/spark pyspark-ml-param_copy-Scala_sync-SPARK-14772-2_1 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/17048.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #17048 ---- commit adeb5b7ea313662a6ab0803acbda1ec8b88bac9f Author: Bryan Cutler <cutl...@gmail.com> Date: 2017-02-01T23:19:57Z fixed Params.copy method to account for _defaultParamMap and match Scala implementation modified test case to include an explicitly set param reworked test to be Python 2.6 compatible ---- --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org