Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/16826#discussion_r103062876
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/internal/SessionState.scala ---
@@ -65,22 +82,118 @@ private[sql] class SessionState(sparkSession:
SparkSession) {
hadoopConf
}
- lazy val experimentalMethods = new ExperimentalMethods
-
/**
- * Internal catalog for managing functions registered by the user.
+ * Get an identical copy of the `SessionState` and associate it with the
given `SparkSession`
*/
- lazy val functionRegistry: FunctionRegistry =
FunctionRegistry.builtin.copy()
+ def clone(newSparkSession: SparkSession): SessionState = {
+ val sparkContext = newSparkSession.sparkContext
+ val confCopy = conf.clone()
+ val functionRegistryCopy = functionRegistry.clone()
+ val sqlParser: ParserInterface = new SparkSqlParser(confCopy)
+ val catalogCopy = catalog.clone(
+ confCopy,
+ SessionState.newHadoopConf(sparkContext.hadoopConfiguration,
confCopy),
+ functionRegistryCopy,
+ sqlParser)
+ val queryExecutionCreator = (plan: LogicalPlan) => new
QueryExecution(newSparkSession, plan)
+
+ SessionState.mergeSparkConf(confCopy, sparkContext.getConf)
+
+ new SessionState(
+ sparkContext,
+ newSparkSession.sharedState,
+ confCopy,
+ experimentalMethods.clone(),
+ functionRegistryCopy,
+ catalogCopy,
+ sqlParser,
+ SessionState.createAnalyzer(newSparkSession, catalogCopy, confCopy),
+ new StreamingQueryManager(newSparkSession),
+ queryExecutionCreator)
+ }
+
+ // ------------------------------------------------------
+ // Helper methods, partially leftover from pre-2.0 days
+ // ------------------------------------------------------
+
+ def executePlan(plan: LogicalPlan): QueryExecution =
queryExecutionCreator(plan)
+
+ def refreshTable(tableName: String): Unit = {
+ catalog.refreshTable(sqlParser.parseTableIdentifier(tableName))
+ }
+
+ def addJar(path: String): Unit = sharedState.addJar(path)
+}
+
+
+object SessionState {
+
+ def apply(sparkSession: SparkSession): SessionState = {
+ apply(sparkSession, None)
+ }
+
+ def apply(
+ sparkSession: SparkSession,
+ conf: Option[SQLConf]): SessionState = {
--- End diff --
why option? the external api should allow user to do
```
SessionState(session)
SessionState(session, existingConf)
```
Doesnt make sense if the user has to write an additional
`Some(existingConf)`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
