Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/16826#discussion_r103067630
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala
---
@@ -274,6 +274,8 @@ private[hive] class HiveClientImpl(
val original = Thread.currentThread().getContextClassLoader
// Set the thread local metastore client to the client associated with
this HiveClientImpl.
Hive.set(client)
+ // replace conf in cached hive with current conf
--- End diff --
A `get` after a `set` looks weird. Actually I need to go back to check Hive
source to know `get` will replace conf with provided one. Shall we move this
into `private def client: Hive` and add comment for it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
