Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/1486#discussion_r17525907 --- Diff: core/src/main/scala/org/apache/spark/rdd/RDD.scala --- @@ -208,8 +208,10 @@ abstract class RDD[T: ClassTag]( } /** - * Get the preferred locations of a partition (as hostnames), taking into account whether the + * Get the preferred locations of a partition, taking into account whether the * RDD is checkpointed. + * The strings returned here can be parsed into TaskLocation objects by --- End diff -- Since `TaskLocation` is an entirely private API I'd leave this out. This sets the expectation that user-defined RDD's can rely on our new tagging scheme, but we didn't make that a public API. Also what if we e.g. refactor or change the `TaskLocation` class. I'd just say we expect it to return a string of hostnames. Or just leave it as is. We can decide as a follow-up whether to expose `TaskLocation`... it might be a good idea to allow user defined RDDs to take advantage of this.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org