Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/16987#discussion_r103151253
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/FileStreamSource.scala
---
@@ -158,12 +158,28 @@ class FileStreamSource(
}
/**
+ * If the source has a metadata log indicating which files should be
read, then we should use it.
+ * We figure out whether there exists some metadata log only when user
gives a non-glob path.
+ */
+ private val sourceHasMetadata: Boolean =
--- End diff --
Just found one corner case: if the query to write files has not yet
started, the current folder will contain no files even it's an output folder of
the file sink. I think we should always call `sourceHasMetadata` until the
folder is not empty.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
