Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/16782#discussion_r103276349
--- Diff: python/pyspark/__init__.py ---
@@ -96,9 +96,11 @@ def keyword_only(func):
"""
@wraps(func)
def wrapper(*args, **kwargs):
+ # NOTE - this assumes we are wrapping a method and args[0] will be
'self'
if len(args) > 1:
raise TypeError("Method %s forces keyword arguments." %
func.__name__)
wrapper._input_kwargs = kwargs
--- End diff --
If the assumption is correct, should we always use 'self' to hold the
kwargs? (remove this line and update all the fuctions that use `keyword_only`)?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
