Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/16784#discussion_r103278706
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/classification/LinearSVCSuite.scala ---
@@ -220,12 +246,13 @@ object LinearSVCSuite {
"aggregationDepth" -> 3
)
- // Generate noisy input of the form Y = signum(x.dot(weights) +
intercept + noise)
+ // Generate noisy input of the form Y = signum(x.dot(weights) +
intercept + noise)
def generateSVMInput(
--- End diff --
This API is strange, where the caller expects numFeatures = weights.size,
but really numFeatures = 10 * weights.size if isDense=false. Please update it
to construct a random dense or sparse vector first (both of length
weights.size) and then compute y to make the API more consistent.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
