Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/2390#discussion_r17526488 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/SqlParser.scala --- @@ -181,11 +182,25 @@ class SqlParser extends StandardTokenParsers with PackratParsers { val overwrite: Boolean = o.getOrElse("") == "OVERWRITE" InsertIntoTable(r, Map[String, Option[String]](), s, overwrite) } + + protected lazy val addCache: Parser[LogicalPlan] = + ADD ~ CACHE ~ TABLE ~> ident ~ AS ~ select <~ opt(";") ^^ { + case tableName ~ as ~ s => + CacheTableAsSelectCommand(tableName,s) + } protected lazy val cache: Parser[LogicalPlan] = - (CACHE ^^^ true | UNCACHE ^^^ false) ~ TABLE ~ ident ^^ { - case doCache ~ _ ~ tableName => CacheCommand(tableName, doCache) + CACHE ~ TABLE ~> ident ~ opt(AS) ~ opt(select) <~ opt(";") ^^ { --- End diff -- Actually `opt(AS ~> select)`, since we don't care the semantic value returned by `AS`.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org