Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/16883#discussion_r103331212
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/StringIndexer.scala ---
@@ -163,25 +190,28 @@ class StringIndexerModel (
}
transformSchema(dataset.schema, logging = true)
+ val metadata = NominalAttribute.defaultAttr
+ .withName($(outputCol)).withValues(labels).toMetadata()
--- End diff --
withValues should include a special field for invalid, if we are keeping
invalid labels. How about calling that field "_invalidLabels" (and defining
this constant in the StringIndexer object)?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
