Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/spark/pull/2390#discussion_r17528595
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/commands.scala ---
    @@ -166,3 +166,22 @@ case class DescribeCommand(child: SparkPlan, output: 
Seq[Attribute])(
           child.output.map(field => Row(field.name, field.dataType.toString, 
null))
       }
     }
    +
    +/**
    + * :: DeveloperApi ::
    + */
    +@DeveloperApi
    +case class CacheTableAsSelectCommand(tableName: String, plan: LogicalPlan)
    +  extends LeafNode with Command {
    +  
    +  override protected[sql] lazy val sideEffectResult = {
    +    sqlContext.catalog.registerTable(None, tableName,  
sqlContext.executePlan(plan).analyzed)
    +    sqlContext.cacheTable(tableName)
    +    // It does the caching eager.
    --- End diff --
    
    Either way is OK. But eager caching is existed only for this feature, so it 
may look inconsistent  compared to other caching commands.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to