Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/spark/pull/2381#discussion_r17528957
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/CachedTableSuite.scala ---
    @@ -119,4 +119,20 @@ class CachedTableSuite extends QueryTest {
         }
         assert(!TestSQLContext.isCached("testData"), "Table 'testData' should 
not be cached")
       }
    +  
    +  test("ADD CACHE TABLE tableName AS SELECT Star Table") {
    +    TestSQLContext.sql("ADD CACHE TABLE testCacheTable AS SELECT * FROM 
testData")
    +    TestSQLContext.sql("SELECT * FROM testCacheTable WHERE key = 
1").collect()
    +    TestSQLContext.uncacheTable("testCacheTable")
    +  }
    +  
    +  test("'ADD CACHE TABLE tableName AS SELECT ..'") {
    +    TestSQLContext.sql("ADD CACHE TABLE testCacheTable AS SELECT * FROM 
testData")
    +    TestSQLContext.table("testCacheTable").queryExecution.executedPlan 
match {
    +      case _: InMemoryColumnarTableScan => // Found evidence of caching
    --- End diff --
    
    OK


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to