Github user chenghao-intel commented on a diff in the pull request:

    https://github.com/apache/spark/pull/2382#discussion_r17531198
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/unresolved.scala
 ---
    @@ -98,12 +98,12 @@ case class Star(
       override def withNullability(newNullability: Boolean) = this
       override def withQualifiers(newQualifiers: Seq[String]) = this
     
    -  def expand(input: Seq[Attribute]): Seq[NamedExpression] = {
    +  def expand(input: Seq[Attribute], resolver: Resolver): 
Seq[NamedExpression] = {
         val expandedAttributes: Seq[Attribute] = table match {
           // If there is no table specified, use all input attributes.
           case None => input
           // If there is a table, pick out attributes that are part of this 
table.
    -      case Some(t) => input.filter(_.qualifiers contains t)
    +      case Some(t) => 
input.filter(_.qualifiers.filter(resolver(_,t)).nonEmpty)
    --- End diff --
    
    Nit: space after `,`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to