Github user stanzhai commented on the issue:

    https://github.com/apache/spark/pull/17099
  
    Thanks for @gatorsmile 's help.
    
    `ConstantFolding` will affect other test cases in 
`FoldablePropagationSuite`.
    
    It's fine without adding `ConstantFolding`.
    
    Before fix:
    ```
    [info]   !'Join Inner, ((a#0 = a#0) && (1 = 1))        'Join Inner, (('tb.a 
= 'ta.a) && ('tb.tag = 'ta.tag))
    [info]   !:- Union                                     :- 'SubqueryAlias ta
    [info]   !:  :- Project [a#0, 1 AS tag#0]              :  +- 'Union
    [info]   !:  :  +- LocalRelation <empty>, [a#0, b#0]   :     :- 'Project 
['a, 1 AS tag#0]
    [info]   !:  +- Project [a#0, 2 AS tag#0]              :     :  +- 
LocalRelation <empty>, [a#0, b#0]
    [info]   !:     +- LocalRelation <empty>, [a#0, b#0]   :     +- 'Project 
['a, 2 AS tag#0]
    [info]   !+- Union                                     :        +- 
LocalRelation <empty>, [a#0, b#0]
    [info]   !   :- Project [a#0, 1 AS tag#0]              +- 'SubqueryAlias tb
    [info]   !   :  +- LocalRelation <empty>, [a#0, b#0]      +- 'Union
    [info]   !   +- Project [a#0, 2 AS tag#0]                    :- 'Project 
['a, 1 AS tag#0]
    [info]   !      +- LocalRelation <empty>, [a#0, b#0]         :  +- 
LocalRelation <empty>, [a#0, b#0]
    [info]   !                                                   +- 'Project 
['a, 2 AS tag#0]
    [info]   !                                                      +- 
LocalRelation <empty>, [a#0, b#0] (PlanTest.scala:99)
    ```
    
    After fix:
    ```
    [info]   !'Join Inner, ((a#0 = a#0) && (tag#0 = tag#0))   'Join Inner, 
(('tb.a = 'ta.a) && ('tb.tag = 'ta.tag))
    [info]   !:- Union                                        :- 'SubqueryAlias 
ta
    [info]   !:  :- Project [a#0, 1 AS tag#0]                 :  +- 'Union
    [info]   !:  :  +- LocalRelation <empty>, [a#0, b#0]      :     :- 'Project 
['a, 1 AS tag#0]
    [info]   !:  +- Project [a#0, 2 AS tag#0]                 :     :  +- 
LocalRelation <empty>, [a#0, b#0]
    [info]   !:     +- LocalRelation <empty>, [a#0, b#0]      :     +- 'Project 
['a, 2 AS tag#0]
    [info]   !+- Union                                        :        +- 
LocalRelation <empty>, [a#0, b#0]
    [info]   !   :- Project [a#0, 1 AS tag#0]                 +- 'SubqueryAlias 
tb
    [info]   !   :  +- LocalRelation <empty>, [a#0, b#0]         +- 'Union
    [info]   !   +- Project [a#0, 2 AS tag#0]                       :- 'Project 
['a, 1 AS tag#0]
    [info]   !      +- LocalRelation <empty>, [a#0, b#0]            :  +- 
LocalRelation <empty>, [a#0, b#0]
    [info]   !                                                      +- 'Project 
['a, 2 AS tag#0]
    [info]   !                                                         +- 
LocalRelation <empty>, [a#0, b#0] (PlanTest.scala:99)
    ```
    
    I just fix the test case(`"tb.tag" -> "tb.tag".attr`).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to