Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/17059#discussion_r103674813
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/recommendation/ALSSuite.scala ---
@@ -205,6 +206,69 @@ class ALSSuite
assert(decompressed.toSet === expected)
}
+ test("CheckedCast") {
+ val checkedCast = new ALS().checkedCast
+ val df = spark.sqlContext.range(1)
+
+ withClue("Valid Integer Ids") {
+ df.select(checkedCast( lit(123) )).collect()
--- End diff --
Could you remove the spaces around `lit(123)` here and throughout for code
style?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
