GitHub user jinxing64 opened a pull request:

    https://github.com/apache/spark/pull/17133

    [SPARK-19793] Use clock.getTimeMillis when mark task as finished in 
TaskSetManager.

    ## What changes were proposed in this pull request?
    
    TaskSetManager is now using `System.getCurrentTimeMillis` when mark task as 
finished in `handleSuccessfulTask` and `handleFailedTask`. Thus developer 
cannot set the tasks finishing time in unit test. When `handleSuccessfulTask`, 
task's duration = `System.getCurrentTimeMillis` - launchTime(which can be set 
by `clock`), the result is not correct.
    
    ## How was this patch tested?
    Existing tests.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jinxing64/spark SPARK-19793

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/17133.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #17133
    
----
commit 56cd922e562ac1aa7a97df01cc16f38a8b3bf250
Author: jinxing <jinxing6...@126.com>
Date:   2017-03-02T09:33:53Z

    [SPARK-19793] Use clock.getTimeMillis when mark task as finished in 
TaskSetManager.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to