Github user actuaryzhang commented on the issue:
https://github.com/apache/spark/pull/17161
I think most examples in R packages are (supposed to be) runnable. Coming
from a user perspective, I find it useful if I can run the examples directly
and see what the function does in action. Since we already have the pseudo-code
here, wouldn't it be better to change it to real data?
Especially for the more complicated cases like `join`, providing
self-contained examples will save users much time in constructing their own
examples.
Indeed, by making the examples runnable, I have found and fixed several
issues with the pseudo example. For example, the original example in
`insertInto` seems to be wrong:
```
createOrReplaceTempView(df, "table1") # This should be saveAsTable
insertInto(df2, "table1", overwrite = TRUE)
```
This is very hard to find without running real examples.
@srowen @felixcheung
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
