Github user chenghao-intel commented on a diff in the pull request:
https://github.com/apache/spark/pull/2397#discussion_r17580822
--- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveQl.scala ---
@@ -229,7 +229,13 @@ private[hive] object HiveQl {
SetCommand(Some(key), Some(value))
}
} else if (sql.trim.toLowerCase.startsWith("cache table")) {
- CacheCommand(sql.trim.drop(12).trim, true)
+ sql.trim.drop(12).trim.split(" ").toSeq match {
+ case Seq(tableName) =>
+ CacheCommand(tableName, true)
+ case Seq(tableName,as, select@_*) =>
--- End diff --
I will suggest to move the `cache table` into the function `nodeToPlan`,
just as we did for token `TOK_CREATETABLE`:
* Parsing the SQL manually probably not the best practice, for example, it
will mis-match for `cache table xxx` (more spaces between `cache` and
`table`)
* `EXPLAIN CACHE TABLE xxx` may not work, since `CACHE TABLE` will be
considered as the `NATIVE COMMAND`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
