Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/17125#discussion_r104338208
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -604,7 +604,13 @@ class Analyzer(
def apply(plan: LogicalPlan): LogicalPlan = plan resolveOperators {
case i @ InsertIntoTable(u: UnresolvedRelation, parts, child, _, _)
if child.resolved =>
- i.copy(table = EliminateSubqueryAliases(lookupTableFromCatalog(u)))
+ val newTable = EliminateSubqueryAliases(lookupTableFromCatalog(u))
+ // Inserting into a view is not allowed, we should throw an
AnalysisException.
+ if (newTable.isInstanceOf[View]) {
--- End diff --
Discussed with @cloud-fan and the concern is that in case the child of the
view node is invalid(e.g. exists cyclic view reference or exceed max reference
depth), we should still indicate that INSERT INTO VIEW is not allowed(instead
of other error messages), so we should not resolve the child of the view,
instead we throw an Exception here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
