Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/17171#discussion_r104367747
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
---
@@ -1476,7 +1476,7 @@ class AstBuilder extends SqlBaseBaseVisitor[AnyRef]
with Logging {
/**
* Create top level table schema.
*/
- protected def createSchema(ctx: ColTypeListContext): StructType = {
+ def createSchema(ctx: ColTypeListContext): StructType = {
--- End diff --
We need to be a little bit careful here. I think we may need to add a rule
similar to `singleDataType` to the grammar and expose its implementation. This
to prevent us from silently dropping trailing input, or having a weird error on
trailing input; it seems we get a somewhat vague error ATM...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
