Github user jkbradley commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16883#discussion_r104489244
  
    --- Diff: 
mllib/src/main/scala/org/apache/spark/ml/feature/StringIndexer.scala ---
    @@ -34,8 +36,27 @@ import org.apache.spark.util.collection.OpenHashMap
     /**
      * Base trait for [[StringIndexer]] and [[StringIndexerModel]].
      */
    -private[feature] trait StringIndexerBase extends Params with HasInputCol 
with HasOutputCol
    -    with HasHandleInvalid {
    +private[feature] trait StringIndexerBase extends Params with HasInputCol 
with HasOutputCol {
    +
    +  /**
    +   * Param for how to handle unseen labels. Options are 'skip' (filter out 
rows with
    +   * unseen labels), 'error' (throw an error), or 'keep' (put unseen 
labels in a special additional
    +   * bucket, at index numLabels.
    +   * Default: "error"
    +   * @group param
    +   */
    +  @Since("2.1.0")
    --- End diff --
    
    I missed this before, but these Since annotations should stay set to 1.6.0 
since handleInvalid and the get/set methods were added in 1.6.0


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to