Github user sarutak commented on a diff in the pull request:
https://github.com/apache/spark/pull/2408#discussion_r17600021
--- Diff: core/src/main/scala/org/apache/spark/network/ManagedBuffer.scala
---
@@ -66,8 +67,13 @@ final class FileSegmentManagedBuffer(val file: File, val
offset: Long, val lengt
override def size: Long = length
override def nioByteBuffer(): ByteBuffer = {
- val channel = new RandomAccessFile(file, "r").getChannel
- channel.map(MapMode.READ_ONLY, offset, length)
+ var channel: FileChannel = null
+ try {
+ channel = new RandomAccessFile(file, "r").getChannel
+ channel.map(MapMode.READ_ONLY, offset, length)
+ } finally {
+ channel.close()
--- End diff --
Originally I was going to check channel is null or not, but I forgot at
previous PR.
Now I've modified.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
