Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/17166#discussion_r104600582
--- Diff: core/src/test/scala/org/apache/spark/SparkContextSuite.scala ---
@@ -538,10 +538,37 @@ class SparkContextSuite extends SparkFunSuite with
LocalSparkContext with Eventu
}
}
+ test("Killing tasks") {
+ sc = new SparkContext(new
SparkConf().setAppName("test").setMaster("local"))
+
+ SparkContextSuite.isTaskStarted = false
+ SparkContextSuite.taskKilled = false
+
--- End diff --
Can you add a comment about what this test is doing? e.g.,
Launches one task that will run forever. Once the SparkListener detects
the task has started, kill and re-schedule it. The second run of the task will
complete immediately. If this test times out, then the first version of the
task wasn't killed successfully.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
