Github user jkbradley commented on the issue:

    https://github.com/apache/spark/pull/17108
  
    Given further thought, I'd prefer we stick to the API specified in the 
design doc, with a Correlations object instead of a generic Statistics object.  
In the future, we may want optional Params such as weightCol, in which case we 
may switch to a builder pattern for Correlations and ChiSquare and move away 
from a shared Statistics object.  I'm going to proceed with 
https://github.com/apache/spark/pull/17110 using a separate ChiSquare object.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to