Github user ioana-delaney commented on the issue:
https://github.com/apache/spark/pull/15363
@wzhfy Thank you, Zhenhua. With the cost based optimizer in place, yes, it
make sense to only call Star schema detection in the context of the new
algorithm.
There are two parts to the current algorithm. The first part is the star
join detection, and the other part does a join reordering based on heuristics.
The latter was implemented for positional join. With the cost-based planning
available, we only need the schema detection. But I might have to retain both
until a complete integration with cbo. So let me refine the logic and call it
from the CostBasedJoinReorder. I will update the PR. Thank you.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
