Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/17179#discussion_r105315158 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/KeyValueGroupedDataset.scala --- @@ -230,16 +231,19 @@ class KeyValueGroupedDataset[K, V] private[sql]( * * @tparam S The type of the user-defined state. Must be encodable to Spark SQL types. * @tparam U The type of the output objects. Must be encodable to Spark SQL types. + * @param func Function to be called on every group. * - * See [[Encoder]] for more details on what types are encodable to Spark SQL. + * See [[Encoder]] for more details on what types are encodable to Spark SQL. --- End diff -- yeah. will take care of those. I have been adding more tests and restructuring the code to make it more testable.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org