Github user mridulm commented on a diff in the pull request:
https://github.com/apache/spark/pull/16788#discussion_r105526225
--- Diff: core/src/main/scala/org/apache/spark/scheduler/ResultTask.scala
---
@@ -60,9 +60,10 @@ private[spark] class ResultTask[T, U](
serializedTaskMetrics: Array[Byte],
jobId: Option[Int] = None,
appId: Option[String] = None,
- appAttemptId: Option[String] = None)
+ appAttemptId: Option[String] = None,
+ tokens: Option[Array[Byte]] = None)
extends Task[U](stageId, stageAttemptId, partition.index,
localProperties, serializedTaskMetrics,
- jobId, appId, appAttemptId)
+ jobId, appId, appAttemptId,tokens)
--- End diff --
Changes to both *Task.scala is changing the security model for not just
mesos, but also yarn - and this is incompatible with existing public api
(credential managers, etc) : unless the PR is planning to overhaul the
security in spark for all cluster managers.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
