Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/17209#discussion_r105548760
--- Diff:
external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaSourceProvider.scala
---
@@ -388,34 +383,34 @@ private[kafka010] class KafkaSourceProvider extends
DataSourceRegister
private def validateBatchOptions(caseInsensitiveParams: Map[String,
String]) = {
// Batch specific options
-
caseInsensitiveParams.get(STARTING_OFFSETS_OPTION_KEY).map(_.trim.toLowerCase)
match {
- case Some("earliest") => // good to go
- case Some("latest") =>
+ KafkaSourceProvider.getKafkaOffsetRangeLimit(
+ caseInsensitiveParams, STARTING_OFFSETS_OPTION_KEY,
EarliestOffsetRangeLimit) match {
+ case EarliestOffsetRangeLimit => // good to go
+ case LatestOffsetRangeLimit =>
throw new IllegalArgumentException("starting offset can't be
latest " +
"for batch queries on Kafka")
- case Some(json) =>
(SpecificOffsetRangeLimit(JsonUtils.partitionOffsets(json)))
- .partitionOffsets.foreach {
+ case specific: SpecificOffsetRangeLimit =>
--- End diff --
nit: `case SpecificOffsetRangeLimit(partitionOffsets) =>`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
