Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16373#discussion_r105560904
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/QueryExecution.scala ---
@@ -123,8 +123,12 @@ class QueryExecution(val sparkSession: SparkSession,
val logical: LogicalPlan) {
.mkString("\t")
}
// SHOW TABLES in Hive only output table names, while ours outputs
database, table name, isTemp.
- case command: ExecutedCommandExec if
command.cmd.isInstanceOf[ShowTablesCommand] =>
- command.executeCollect().map(_.getString(1))
+ case command@ ExecutedCommandExec(showTables: ShowTablesCommand) =>
+ if (showTables.isExtended) {
+ command.executeCollect().map(_.getString(3))
--- End diff --
If we do not have it, any test case failed?
This function is just for testing. If we do not have the related Hive
output comparison. We can simplify it to
```Scala
case command @ ExecutedCommandExec(showTables: ShowTablesCommand) if
!showTables.isExtended =>
command.executeCollect().map(_.getString(1))
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
