Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/2350#discussion_r17641097
  
    --- Diff: 
yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ClientBase.scala ---
    @@ -417,41 +381,136 @@ trait ClientBase extends Logging {
             "1>", ApplicationConstants.LOG_DIR_EXPANSION_VAR + "/stdout",
             "2>", ApplicationConstants.LOG_DIR_EXPANSION_VAR + "/stderr")
     
    -    logInfo("Yarn AM launch context:")
    -    logInfo(s"  user class: ${args.userClass}")
    -    logInfo(s"  env:        $env")
    -    logInfo(s"  command:    ${commands.mkString(" ")}")
    -
         // TODO: it would be nicer to just make sure there are no null 
commands here
         val printableCommands = commands.map(s => if (s == null) "null" else 
s).toList
         amContainer.setCommands(printableCommands)
     
    -    setupSecurityToken(amContainer)
    +    
logDebug("===============================================================================")
    --- End diff --
    
    This is unnecessary because the implementation of `logDebug` already does 
the check.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to