Github user jkbradley commented on the issue:
https://github.com/apache/spark/pull/17218
Thanks for the PR! I'll wait until this isn't "WIP" to review it
thoroughly, but I'll make two comments now:
* The params should not be added to shared.py since they are not shared by
any other algorithm. They can be added later if needed, but I expect them not
to be since the documentation for these in particular should be specialized for
FPM algorithms.
* For future reference: Never add stuff directly to shared.py; it should go
in the generating file in the same folder.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
