Github user yanjidriveai commented on a diff in the pull request:
https://github.com/apache/spark/pull/17109#discussion_r105760039
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerBackendUtil.scala
---
@@ -99,6 +99,26 @@ private[mesos] object MesosSchedulerBackendUtil extends
Logging {
.toList
}
+ /**
+ * Parse a list of docker parameters, each of which
+ * takes the form key=value
+ */
+ private def parseParamsSpec(params: String): List[Parameter] = {
+ params.split(",").map(_.split("=")).flatMap { spec: Array[String] =>
--- End diff --
to be consistent with other methods, i think we should stick with spec.
> def parsePortMappingsSpec(portmaps: String):
List[DockerInfo.PortMapping] = {
> portmaps.split(",").map(_.split(":")).flatMap { spec: Array[String] =>
> val portmap: DockerInfo.PortMapping.Builder = DockerInfo.PortMapping
it seems to be better to reserve the name parameter later for builder
> val param: Parameter.Builder = Parameter.newBuilder()
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
