Github user hvanhovell commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17278#discussion_r105764212
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
 ---
    @@ -140,7 +140,8 @@ abstract class Optimizer(sessionCatalog: 
SessionCatalog, conf: CatalystConf)
       object OptimizeSubqueries extends Rule[LogicalPlan] {
         def apply(plan: LogicalPlan): LogicalPlan = plan 
transformAllExpressions {
           case s: SubqueryExpression =>
    -        s.withNewPlan(Optimizer.this.execute(s.plan))
    +        val ReturnAnswer(newPlan) = 
Optimizer.this.execute(ReturnAnswer(s.plan))
    --- End diff --
    
    I can rename it if you think that is better. It seems a bit silly to me to 
have two logical plan nodes for this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to