Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/17182#discussion_r105774957
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/functions.scala
---
@@ -63,7 +63,10 @@ case class CreateFunctionCommand(
} else {
// For a permanent, we will store the metadata into underlying
external catalog.
// This function will be loaded into the FunctionRegistry when a
query uses it.
- // We do not load it into FunctionRegistry right now.
+ // We do not load it into FunctionRegistry right now. However, we
need to validate.
+ catalog.loadFunctionResources(resources)
+ catalog.makeFunctionBuilder(functionName, className)
--- End diff --
I did a try in my local environment. It works well if we register it to
`FunctionRegistry ` directly. I did not see the reason why we just validate it
only. That is why I think this is not in a right direction.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
