Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/2397#discussion_r17648914
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/commands.scala ---
@@ -166,3 +166,20 @@ case class DescribeCommand(child: SparkPlan, output:
Seq[Attribute])(
child.output.map(field => Row(field.name, field.dataType.toString,
null))
}
}
+
+/**
+ * :: DeveloperApi ::
+ */
+@DeveloperApi
+case class CacheTableAsSelectCommand(tableName: String, plan: LogicalPlan)
+ extends LeafNode with Command {
+
+ override protected[sql] lazy val sideEffectResult = {
+ sqlContext.catalog.registerTable(None, tableName,
sqlContext.executePlan(plan).analyzed)
--- End diff --
(Probably my final comment on this PR :) )
As described in PR #2382, we shouldn't store analyzed logical plan when
registering tables any more (see
[here](https://github.com/apache/spark/pull/2382/files?diff=split#diff-5)).
To prevent duplicated code, I'd suggest to import `SQLContext._` so that we
can leverage [the implicit
conversion](https://github.com/apache/spark/blob/008a5ed4808d1467b47c1d6fa4d950cc6c4976b7/sql/core/src/main/scala/org/apache/spark/sql/SQLContext.scala#L78-L85)
from `LogicalPlan` to `SchemaRDD`, and then simply do this:
```scala
sqlContext.executePlan(plan).logical.registerTempTable(tableName)
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
