Github user ericl commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17166#discussion_r106066177
  
    --- Diff: 
core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala ---
    @@ -710,7 +710,11 @@ private[spark] class TaskSetManager(
           logInfo(s"Killing attempt ${attemptInfo.attemptNumber} for task 
${attemptInfo.id} " +
             s"in stage ${taskSet.id} (TID ${attemptInfo.taskId}) on 
${attemptInfo.host} " +
             s"as the attempt ${info.attemptNumber} succeeded on ${info.host}")
    -      sched.backend.killTask(attemptInfo.taskId, attemptInfo.executorId, 
true)
    +      sched.backend.killTask(
    +        attemptInfo.taskId,
    +        attemptInfo.executorId,
    +        interruptThread = true,
    +        reason = "another attempt succeeded")
    --- End diff --
    
    I added two screenshots to the PR description. In the second scenario 
having a verbose reason is fine, but in the stage summary view long or many 
distinct reasons would overflow the progress bar.
    
    We could probably fix the css to allow slightly longer / more reasons, but 
even that wouldn't be great if each task had a different reason.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to