Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/17292#discussion_r106130808
--- Diff: core/src/test/scala/org/apache/spark/DebugFilesystem.scala ---
@@ -44,7 +44,8 @@ object DebugFilesystem extends Logging {
logWarning("Leaked filesystem connection created at:")
exc.printStackTrace()
}
- throw new RuntimeException(s"There are $numOpen possibly leaked file
streams.")
+ throw new RuntimeException(s"There are $numOpen possibly leaked file
streams.",
--- End diff --
This is a style nit, but while we're here, I wouldn't mind avoiding
RuntimeException. IllegalStateException is more specific and canonical. No big
deal, just if you're making another change anwyay.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
