Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/16905#discussion_r106244124
--- Diff:
core/src/test/scala/org/apache/spark/scheduler/TaskSchedulerImplSuite.scala ---
@@ -73,17 +73,15 @@ class TaskSchedulerImplSuite extends SparkFunSuite with
LocalSparkContext with B
}
}
- def setupScheduler(confs: (String, String)*): TaskSchedulerImpl = {
+ private def setupScheduler(confs: (String, String)*): TaskSchedulerImpl
= {
--- End diff --
one quick comment here if Imran didn't already merge: can you un-do these
changes? It's not useful / necessary to make test classes private (they're
already hidden by the build), and this change will make git blames more
confusing in the future.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
