Github user derrickburns commented on the pull request:
https://github.com/apache/spark/pull/2419#issuecomment-55898846
I agree that some of my comments should go in the code.
As for the Big Bang change, I understand your concern. The distance
functions touches practically everything. The change in the treatment of number
of clusters is also a broad change. So, while I would prefer to make small
increment changes, these two changes required touching lots of code.
Sent from my iPhone
> On Sep 17, 2014, at 12:33 AM, Sean Owen <notificati...@github.com> wrote:
>
> @derrickburns I think these notes can go in code comments? (They each
generate their own email too.)
>
> This is also a big-bang change covering several issues, some of which
seem like more focused bug fixes or improvements. I would think it would be
easier to break this down further if possible, and get in clear easy changes
first.
>
> â
> Reply to this email directly or view it on GitHub.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
