GitHub user cloud-fan opened a pull request:
https://github.com/apache/spark/pull/17315
[SPARK-19949][SQL] unify bad record handling in CSV and JSON
## What changes were proposed in this pull request?
Currently JSON and CSV have exactly the same logic about handling bad
records, this PR tries to abstract it and put it in a upper level to reduce
code duplication.
The overall idea is, we make the JSON and CSV parser to throw a
BadRecordException, then the upper level, FailureSafeParser, handles bad
records according to the parse mode.
Behavior changes:
1. with PERMISSIVE mode, if the number of tokens doesn't match the schema,
previously CSV parser will treat it as a legal record and parse as many tokens
as possible. After this PR, we treat it as an illegal record, and put the raw
record string in a special column, but we still parse as many tokens as
possible.
2. all logging is removed as they are not very useful in practice.
## How was this patch tested?
existing tests
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cloud-fan/spark bad-record2
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/17315.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #17315
----
commit adfde77125eb31b262a2f010851beef2b872e1e8
Author: Wenchen Fan <wenc...@databricks.com>
Date: 2017-03-16T13:52:59Z
unify bad record handling in CSV and JSON
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
