Github user wzhfy commented on a diff in the pull request:
https://github.com/apache/spark/pull/17286#discussion_r106603543
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/JoinReorderSuite.scala
---
@@ -187,6 +220,8 @@ class JoinReorderSuite extends PlanTest with
StatsEstimationTestBase {
case (j1: Join, j2: Join) =>
(sameJoinPlan(j1.left, j2.left) && sameJoinPlan(j1.right,
j2.right)) ||
(sameJoinPlan(j1.left, j2.right) && sameJoinPlan(j1.right,
j2.left))
+ case _ if plan1.children.nonEmpty && plan2.children.nonEmpty =>
--- End diff --
If they are two projects, we should recurse into it's child. And we may
have some tests with other operators in the future, so I didn't only match
project here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
