Github user xwu0226 commented on a diff in the pull request:
https://github.com/apache/spark/pull/16626#discussion_r106682149
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalogSuite.scala
---
@@ -450,6 +451,26 @@ abstract class SessionCatalogSuite extends PlanTest {
}
}
+ test("alter table add columns") {
+ withBasicCatalog { sessionCatalog =>
+ sessionCatalog.createTable(newTable("t1", "default"), ignoreIfExists
= false)
+ val oldTab = sessionCatalog.externalCatalog.getTable("default", "t1")
+ sessionCatalog.alterTableSchema(TableIdentifier("t1",
Some("default")),
+ oldTab.schema.add("c3", IntegerType))
+ val newTab = sessionCatalog.externalCatalog.getTable("default", "t1")
+ if (sessionCatalog.externalCatalog.isInstanceOf[InMemoryCatalog]) {
+ assert(newTab.schema.toString == oldTab.schema.add("c3",
IntegerType).toString)
--- End diff --
`StructField` returned from `CatalogTable` has metadata field that contains
some hive related information, which the manually added schema field does not
have. So directly comparing 2 `StructType` returns false. `toString` method of
`StructField` does not include metadata field.. But I think this may not be a
good way to test anyway.. I will modify this test case..
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
