Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/15435#discussion_r106726649 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala --- @@ -813,9 +835,16 @@ class LogisticRegressionModel private[spark] ( @Since("2.0.0") def evaluate(dataset: Dataset[_]): LogisticRegressionSummary = { // Handle possible missing or invalid prediction columns - val (summaryModel, probabilityColName) = findSummaryModelAndProbabilityCol() - new BinaryLogisticRegressionSummary(summaryModel.transform(dataset), - probabilityColName, $(labelCol), $(featuresCol)) + val (summaryModel, probabilityColName, predictionColName) --- End diff -- put this on a single line. also, it happens above so do it there as well
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org