Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17338#discussion_r106776627
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala 
---
    @@ -700,20 +701,33 @@ abstract class DDLSuite extends QueryTest with 
SQLTestUtils {
     
       test("create temporary view using") {
         val csvFile =
    -      
Thread.currentThread().getContextClassLoader.getResource("test-data/cars.csv").toString
    -    withView("testview") {
    -      sql(s"CREATE OR REPLACE TEMPORARY VIEW testview (c1 String, c2 
String)  USING " +
    -        "org.apache.spark.sql.execution.datasources.csv.CSVFileFormat  " +
    -        s"OPTIONS (PATH '$csvFile')")
    +      
Thread.currentThread().getContextClassLoader.getResourceAsStream("test-data/cars.csv")
    --- End diff --
    
    I guess I don't yet see how this differs -- why does it get the right path 
whereas the previous one didn't? they're both dereferencing a resource relative 
to the same classloader.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to