Github user mridulm commented on a diff in the pull request:
https://github.com/apache/spark/pull/17295#discussion_r106778888
--- Diff:
core/src/main/scala/org/apache/spark/storage/DiskBlockManager.scala ---
@@ -94,7 +101,11 @@ private[spark] class DiskBlockManager(conf: SparkConf,
deleteFilesOnStop: Boolea
}
}.filter(_ != null).flatMap { dir =>
val files = dir.listFiles()
- if (files != null) files else Seq.empty
+ if (files != null) {
+ files.filter(!_.getName().endsWith(METADATA_FILE_SUFFIX))
+ } else {
+ Seq.empty
+ }
--- End diff --
getAllFiles should be returning all files stored.
For example, test suite's use getAllFiles to remove all files using this
api.
On other hand, getAllBlocks needs to ensure metadata file's are filtered
out - this check should be moved there.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
