Github user windpiger commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17340#discussion_r106780030
  
    --- Diff: 
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalogSuite.scala
 ---
    @@ -196,50 +196,6 @@ abstract class ExternalCatalogSuite extends 
SparkFunSuite with BeforeAndAfterEac
         catalog.dropTable("db2", "unknown_table", ignoreIfNotExists = true, 
purge = false)
       }
     
    -  test("rename table") {
    -    val catalog = newBasicCatalog()
    -    assert(catalog.listTables("db2").toSet == Set("tbl1", "tbl2"))
    -    catalog.renameTable("db2", "tbl1", "tblone")
    -    assert(catalog.listTables("db2").toSet == Set("tblone", "tbl2"))
    -  }
    -
    -  test("rename table when database/table does not exist") {
    -    val catalog = newBasicCatalog()
    -    intercept[AnalysisException] {
    -      catalog.renameTable("unknown_db", "unknown_table", "unknown_table")
    -    }
    -    intercept[AnalysisException] {
    -      catalog.renameTable("db2", "unknown_table", "unknown_table")
    -    }
    -  }
    -
    -  test("rename table when destination table already exists") {
    -    val catalog = newBasicCatalog()
    -    intercept[AnalysisException] {
    -      catalog.renameTable("db2", "tbl1", "tbl2")
    -    }
    -  }
    -
    -  test("alter table") {
    --- End diff --
    
    already existed in SessionCatalog


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to