Github user codedeft commented on the pull request: https://github.com/apache/spark/pull/2435#issuecomment-55974486 @jkbradley Thanks Joseph. It makes sense. It looks good upon very rough browsing. Some minor things: * Would be nice to have support for without-replacement in Bagging (I noticed a TODO comment there already...) * Would be nice to have support for manual feature subset size.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org